Adjust spacings and alignment for Divi #6883
Conversation
gabrielcaires
changed the base branch from
trunk
to
feature/learning-mode-improvements
gabrielcaires
changed the base branch from
feature/learning-mode-improvements
to
update/spacing-course-theme
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Codecov Report
@@ Coverage Diff @@
## feature/learning-mode-improvements #6883 +/- ##
=====================================================================
Coverage 47.21% 47.21%
Complexity 10131 10131
=====================================================================
Files 499 499
Lines 35886 35886
Branches 283 283
=====================================================================
Hits 16945 16945
Misses 18729 18729
Partials 212 212 Continue to review full report in Codecov by Sentry.
|
|
Front end looks pretty good. Here are a few issues I noticed: Too little space between the paragraph and the video above: No space at all between the lesson name and the module name: By design, it is 24px: Too much space in the navigation for lessons without modules: Too little space on the top of the content area: |
|
@merkushin I didn't have success reproducing the issues after I updated the branch. 
I tried to recreate my env to try to reproduce. Could you please check again? I am still trying to figure out if my env is reliable. |
|
@gabrielcaires Divi-LM-Appearance.mov |
includes/3rd-party/themes/divi.php
Outdated
| * Enqueue Course theme-specific Learning Mode styles in the admin for the Site Editor and Lesson Editor. | ||
| */ | ||
| function sensei_admin_load_learning_mode_style_for_divi_theme() { | ||
| $is_course_theme = 'divi' === wp_get_theme()->get_template(); |
There was a problem hiding this comment.
Should this variable be named $is_divi_theme or something like that?
There was a problem hiding this comment.
Fixed here 2703ebb
includes/3rd-party/themes/divi.php
Outdated
|
|
||
| if ( $is_lesson_editor || $is_site_editor ) { | ||
| Sensei()->assets->enqueue( | ||
| 'div-learning-mode', |
There was a problem hiding this comment.
Should this be divi-learning-mode?
There was a problem hiding this comment.
Fixed here 2703ebb
includes/3rd-party/themes/divi.php
Outdated
| */ | ||
| function sensei_load_learning_mode_style_for_divi_theme() { | ||
| $course_id = Sensei_Utils::get_current_course(); | ||
| $is_course_theme = 'divi' === wp_get_theme()->get_template(); |
There was a problem hiding this comment.
Should this variable be named $is_divi_theme or something like that?
There was a problem hiding this comment.
Fixed here 2703ebb
includes/3rd-party/themes/divi.php
Outdated
| ); | ||
|
|
||
| Sensei()->assets->enqueue( | ||
| 'div-learning-mode-editor', |
There was a problem hiding this comment.
Should this be divi-learning-mode-editor?
There was a problem hiding this comment.
Fixed here 2703ebb
includes/3rd-party/themes/divi.php
Outdated
| @@ -89,4 +89,54 @@ function sensei_fix_divi_learning_mode_video_template_excerpt() { | |||
| remove_filter( 'render_block_core/post-excerpt', array( ET_GB_Block_Post_Excerpt::instance(), 'render_block' ) ); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Enqueue Course theme-specific Learning Mode styles. | |||
There was a problem hiding this comment.
Fixed here 2703ebb
includes/3rd-party/themes/divi.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Enqueue Course theme-specific Learning Mode styles in the admin for the Site Editor and Lesson Editor. |
There was a problem hiding this comment.
Fixed here 2703ebb
|
I've introduced a small fix here, otherwise it wasn't working for me locally bac7054 |
|
After Imran's fix, issues with spacing in content part on desktop were resolved.
|
|
@merkushin As I described here due to some reason that I couldn't identify, I can not reproduce it, so I removed the change I introduced based on my env. [8ca3169] |
|
Merging into the feature branch as it's approved 🎆 |
Resolves #6856
Proposed Changes
Testing Instructions
Pre-Merge Checklist