New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of excerpts #2330

Merged
merged 3 commits into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@donnapep
Contributor

donnapep commented Nov 20, 2018

This fixes some escaping issues with excerpts, which can contain HTML.

Testing

  1. Switch to the Twenty Seventeen theme.
  2. Add enough content to a course that it will be truncated wherever an excerpt is shown. Ensure the course does not have an excerpt.
  3. Browse to the course archive or course category page and ensure the course description shows a "Continue Reading" link.
  4. In Sensei > Settings > General, check the Access Permissions checkbox.
  5. Add an excerpt to a non-preview lesson.
  6. As a logged out user, browse to that lesson and ensure the excerpt appears as expected.
  7. Add a long message, or edit an existing message, so that it will be truncated wherever an excerpt is shown.
  8. Browse to the message archive page and ensure the truncated message shows a "Continue Reading" link.

@donnapep donnapep self-assigned this Nov 20, 2018

@donnapep donnapep added this to the 1.12.2 milestone Nov 20, 2018

@donnapep donnapep requested review from alexsanford and jom Nov 20, 2018

@alexsanford

🚢

@donnapep donnapep merged commit 66f92d3 into master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@donnapep donnapep deleted the fix/escaping-excerpt branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment