Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added login notice to single lesson & single quiz pages. #3299

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Open

Added login notice to single lesson & single quiz pages. #3299

wants to merge 13 commits into from

Commits on Jun 16, 2020

  1. Added login notice to single lesson page.

    @hansschuijff
    hansschuijff committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5c471c1 View commit details
    Browse the repository at this point in the history

  2. Lint-errors corrected

    @hansschuijff
    hansschuijff committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    58454ec View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Correct @Version comment of lesson add_action.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    9cca14e View commit details
    Browse the repository at this point in the history

  2. Added login notice to single quiz too.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    de6ade7 View commit details
    Browse the repository at this point in the history

  3. Fixed small error: $id instead of $lesson_id.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    12fc0bf View commit details
    Browse the repository at this point in the history

  4. Fixed reported lint error.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    cfe010c View commit details
    Browse the repository at this point in the history

  5. Small docblock change.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    5f85237 View commit details
    Browse the repository at this point in the history

  6. Corrected the comment on login_notice in utils.

    @hansschuijff
    hansschuijff committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bf4ad87 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Applied info box styles also to module pages. 

    Added .module-container to info-box selectors so
styling of sensei messages on module pages is consistent
with other sensei pages.
    @hansschuijff
    hansschuijff committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    de69619 View commit details
    Browse the repository at this point in the history

  2. No course signup notice on lesson when logged out. 

    Don't show course signup notice when user is not logged in.
In that case the user is prompted to log in first.
    @hansschuijff
    hansschuijff committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    e9a719a View commit details
    Browse the repository at this point in the history

  3. Changed Quiz to quiz in course signup notice.

    @hansschuijff
    hansschuijff committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f9fa2ad View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Don't show other notices when user should login. 

    - Changed login_notice text to "Please log in to access {lesson|quiz}".
- Used Sensei()->notices->add_notice() for quiz notices too.
- Uses Sensei()->notices->add_notice() also for quiz saved message.
- Probably Sensei()->frontend->messages is now redundant,
  but kept it just in case.
    @hansschuijff
    hansschuijff committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    80f592e View commit details
    Browse the repository at this point in the history

  2. Added login notice to module pages.

    @hansschuijff
    hansschuijff committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4c67cbf View commit details
    Browse the repository at this point in the history