Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP notice when viewing course category page on unsupported themes #3608

Merged
merged 1 commit into from Sep 15, 2020
Merged

Fix PHP notice when viewing course category page on unsupported themes #3608

merged 1 commit into from Sep 15, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Sep 14, 2020

Fixes #3540

Changes proposed in this Pull Request

  • Add term object to page imitator, similar to some other pages.

Testing instructions

  1. Activate Twenty Nineteen or Twenty Twenty theme.
  2. Add a course category to a course.
  3. Browse to /course-category/<category-slug>.
  4. Check the logs.

@renatho renatho added this to the 3.5.2 milestone Sep 14, 2020
@renatho renatho self-assigned this Sep 14, 2020
@renatho renatho marked this pull request as draft September 14, 2020 19:57
@renatho renatho marked this pull request as ready for review September 14, 2020 20:34
gikaragia
gikaragia approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good works well!

@renatho renatho merged commit bc0f7f6 into release/3.5.2 Sep 15, 2020
@renatho renatho deleted the fix/unsupported-themes-error branch September 15, 2020 18:14
@donnapep donnapep mentioned this pull request Sep 16, 2020
Closed
@donnapep donnapep changed the title Add term object to page imitator Fix PHP notice when viewing course category page on unsupported themes Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees

@renatho renatho

Labels
[Type] Bug
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renatho @gikaragia