Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new blocks to the course block template #3734

Merged
merged 1 commit into from Oct 26, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 22, 2020

Changes proposed in this Pull Request

  • Update course CPT template, adding the new blocks.
  • Review spacings in the frontend. (will be tackled in next PRs).

Testing instructions

  • Create a new course.
  • Make sure the course starts with:
    • Take course button.
    • Course progress.
    • Contact teacher.

Observation: There are some vertical spacing issues in the frontend that will be tackled in next PRs.

Screenshot / Video

Screen Shot 2020-10-22 at 13 39 40

@renatho renatho added this to the 3.6.0 milestone Oct 22, 2020
@renatho renatho requested a review from a team October 22, 2020 16:42
@renatho renatho self-assigned this Oct 22, 2020
@donnapep
Copy link
Collaborator

@renatho Is this still in progress?

@renatho
Copy link
Contributor Author

renatho commented Oct 23, 2020

@renatho Is this still in progress?

Hey @donnapep ! Yep! It depends on #3702 and after that would be good a re-check on the spacings between the blocks ;)

I'm planning to re-check that PR after another thing I'm working on to see if we can merge, or if there's still pending things to do.

@donnapep
Copy link
Collaborator

OK, that's great. If there's a solution for block margins in that other PR, then we'll be able to de-prioritize the template research card.

@renatho
Copy link
Contributor Author

renatho commented Oct 23, 2020

OK, that's great. If there's a solution for block margins in that other PR, then we'll be able to de-prioritize the template research card.

I don't think so. I think we can keep it prioritized and investigate that there so.

@renatho renatho marked this pull request as ready for review October 23, 2020 18:39
@gikaragia
Copy link
Contributor

Maybe the order should be 'Take course', 'Course outline', 'Course progress', 'Contact teacher'?

@donnapep
Copy link
Collaborator

I'm not sure we should change the order from what it currently is in the template. While it may be better for new users, for old users with existing courses, it would mean they'd need to re-order the blocks to keep it consistent with their other courses.

@renatho renatho merged commit ce434d8 into master Oct 26, 2020
@renatho renatho deleted the change/course-cpt-template branch October 26, 2020 22:39
@renatho
Copy link
Contributor Author

renatho commented Oct 26, 2020

Merging this for now. Maybe after having the styles/spacings working well, we can revisit that. Pablo shared some ideas on the Sensei Design channel. ;)

@donnapep donnapep changed the title Add new blocks to the course CPT template Add new blocks to the courses block template Oct 27, 2020
@donnapep donnapep changed the title Add new blocks to the courses block template Add new blocks to the course block template Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants