Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default border radius in the course progress block #3781

Merged
merged 1 commit into from Nov 16, 2020
Merged

Update default border radius in the course progress block #3781

merged 1 commit into from Nov 16, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Nov 16, 2020

Changes proposed in this Pull Request

  • Update default border radius in the progress bar to 10px.

Notice that considering our current height, it's the maximum border-radius. Increase more will only have effect increasing the height too.

Testing instructions

  • Create a new course with a progress bar, and make sure the default radius is 10px.

Screenshot / Video

Screen Shot 2020-11-16 at 11 42 11

@renatho renatho added this to the 3.6.0 milestone Nov 16, 2020
@renatho renatho requested a review from a team November 16, 2020 14:47
@renatho renatho self-assigned this Nov 16, 2020
jom
jom approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better!

@renatho renatho merged commit acc27b8 into master Nov 16, 2020
@renatho renatho deleted the change/progress-bar-border-radius branch November 16, 2020 19:28
@donnapep donnapep changed the title Update default border radius in the progress bar Update default border radius in the course progress block Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

Assignees

@renatho renatho

Labels
[Type] Enhancement
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renatho @jom