Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module and lesson title styles #3797

Merged
merged 3 commits into from Nov 20, 2020
Merged

Fix module and lesson title styles #3797

merged 3 commits into from Nov 20, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 19, 2020 •
edited

Changes proposed in this Pull Request

  • Fix visual regression - Modules titles had underline on some themes when links to the module page were added
  • Storefront also has a pretty large specificity on link styles, so this picks up that arms race 馃槱

Testing instructions

  • View a course with modules and lessons in an outline block on Storefront theme
  • Ensure that module header and lesson styles look the same as the editor (with no underlines)
  • Also check that things look right on other theme

@yscik yscik added this to the 3.6.0 milestone Nov 19, 2020
@yscik yscik requested a review from a team November 19, 2020 16:22
@yscik yscik changed the title Fix module, lesson title link styles Fix module, lesson title styles Nov 19, 2020
renatho
renatho approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh, the styles' nightmare! haha

Looks good and works well! 馃拝

@yscik yscik merged commit 249fff1 into master Nov 20, 2020
@yscik yscik deleted the fix/module-title-link-style branch November 20, 2020 19:43
@donnapep donnapep changed the title Fix module, lesson title styles Fix module and lesson title styles Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yscik @renatho