Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook to filter meta keys when duplicating courses #3830

Merged
merged 2 commits into from Jan 4, 2021
Merged

Add hook to filter meta keys when duplicating courses #3830

merged 2 commits into from Jan 4, 2021

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Dec 8, 2020 •
edited by donnapep

Needed for a fix in WCPC extension.

Changes proposed in this Pull Request

  • Add sensei_duplicate_post_ignore_meta filter with the meta keys skipped when duplicating content.

Testing instructions

  • See 562-gh-Automattic/sensei-wc-paid-courses

New/Updated Hooks

  • sensei_duplicate_post_ignore_meta - Meta keys to ignore when duplicating content.

@yscik yscik requested a review from a team December 9, 2020 11:52
@yscik yscik marked this pull request as ready for review December 9, 2020 11:52
jom
jom reviewed Dec 10, 2020
View reviewed changes
includes/class-sensei-admin.php Outdated
/**
* Ignored meta fields when duplicating a post.
*
* @hook sensei_duplicate_content_ignore_meta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched hook name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9935436

jom
jom requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

@alexsanford alexsanford requested a review from jom December 22, 2020 16:21
@yscik yscik merged commit 97947c3 into master Jan 4, 2021
@yscik yscik deleted the add/duplicate-meta-filter branch January 4, 2021 18:12
@donnapep donnapep added the Hooks This change adds or modifies one or more hooks. label Jan 4, 2021
@donnapep donnapep added this to the 3.7.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford left review comments

@jom jom jom approved these changes

Assignees
No one assigned
Labels
Hooks This change adds or modifies one or more hooks.
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yscik @jom @alexsanford @donnapep