Handle lesson hooks for lessons which contain a block #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gikaragia
changed the title
gikaragia
force-pushed
the
add/handle-lesson-hooks
branch
3 times, most recently
from
6df8b76
to
ab04e5c
Compare
|
It seems that when I moved the 'Contact Teacher' notice to the constructor I forgot to remove the previous one. This is now fixed. |
renatho
previously approved these changes
Jan 29, 2021
| @@ -33,6 +33,11 @@ public function register_block() { | |||
| 'render_callback' => [ $this, 'render_contact_teacher_block' ], | |||
| ] | |||
| ); | |||
|
|
|||
| // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- Arguments used for comparison. | |||
There was a problem hiding this comment.
Not critical, but WDYT to handle it separately since it's not related to the block register?
gikaragia
force-pushed
the
add/handle-lesson-hooks
branch
from
606e985
to
ae77c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
footer_quiz_call_to_actionandsend_message_link. Methodsend_message_linkadds a notice which is going to be handled by the Contact Teacher block. Methodfooter_quiz_call_to_actiondoes not add any notices which means that no other changes for notices are required.Testing instructions