Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hide export button when no results on "Students taking course" screen #5121

Merged
merged 4 commits into from May 16, 2022
Merged

Fix hide export button when no results on "Students taking course" screen #5121

merged 4 commits into from May 16, 2022

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented May 13, 2022

Changes proposed in this Pull Request

  • Hides the export button when there are no results.

Testing instructions

  • Go to Sensei LMS -> Reports -> Courses -> [a course] -> Students taking this Course (tab)
  • Use the filters so you don't see any results.
  • There should be no "Export all rows" button.

@m1r0 m1r0 self-assigned this May 13, 2022
@m1r0 m1r0 requested a review from a team May 13, 2022 18:27
@m1r0 m1r0 added this to the 4.4.1 - Report improvements milestone May 13, 2022
@m1r0 m1r0 marked this pull request as ready for review May 13, 2022 18:27
Base automatically changed from feature/reports-v3 to trunk May 16, 2022 10:04
merkushin
merkushin previously approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@m1r0 m1r0 merged commit 9026fd0 into trunk May 16, 2022
@m1r0 m1r0 deleted the fix/hide-export-button-when-no-results branch May 16, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin left review comments

Assignees

@m1r0 m1r0

Labels
[Type] Bug
Projects
None yet
Milestone
4.4.1 - Report Improvements
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m1r0 @merkushin