New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set current time to keep the same behavior for all players #5416
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #5416 +/- ##
=========================================
Coverage 44.55% 44.56%
Complexity 8728 8728
=========================================
Files 412 412
Lines 31115 31115
Branches 234 234
=========================================
+ Hits 13864 13865 +1
+ Misses 17078 17077 -1
Partials 173 173
Continue to review full report at Codecov.
|
4ee5886
to
b47898d
Compare
/** | ||
* Variable that saves the last current time. | ||
*/ | ||
let lastCurrentTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just moved, renamed, and documented.
b47898d
to
e249111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well! 🚀
Based on #5410
Changes proposed in this Pull Request
setCurrentTime
, in order to work in the same way for all the players. Basically, we need to have played a video in some players in order to have the frame updated when calling thesetCurrentTime
, so if the video wasn't played yet, we just play and pause to make it work.Testing instructions