Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Re-engaging customers. #6821

Merged
merged 27 commits into from
May 5, 2023
Merged

Feature: Re-engaging customers. #6821

merged 27 commits into from
May 5, 2023

Conversation

aaronfc
Copy link
Contributor

@aaronfc aaronfc commented Apr 18, 2023

Aggregates some changes in order to improve discoverability of Sensei and Sensei Pro updates.

Changes included

Testing Instructions

  • Sanity: Test that updates for Sensei Pro are displayed in Plugins page as usual.
  • Sanity: Test that remote conditions are displayed as usual.
  • More detailed steps in each PR above.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate/
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit f13e2b6 and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
css/senseilms-licensing.js wp-polyfill 24 B +24 B ( +100% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #6821 (f13e2b6) into trunk (90e8a14) will decrease coverage by 0.10%.
The diff coverage is 23.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #6821      +/-   ##
============================================
- Coverage     47.40%   47.30%   -0.10%     
- Complexity    10119    10168      +49     
============================================
  Files           499      500       +1     
  Lines         35974    36097     +123     
  Branches        283      283              
============================================
+ Hits          17054    17077      +23     
- Misses        18708    18808     +100     
  Partials        212      212              
Impacted Files Coverage Δ
includes/admin/class-senseilms-plugin-updater.php 0.00% <0.00%> (ø)
includes/class-sensei.php 26.49% <0.00%> (-0.07%) ⬇️
.../course-theme/class-sensei-course-theme-editor.php 8.42% <0.00%> (-0.09%) ⬇️
includes/admin/class-sensei-admin-notices.php 51.06% <83.33%> (+3.73%) ⬆️
...ome/notices/class-sensei-home-notices-provider.php 100.00% <100.00%> (+6.06%) ⬆️
...s/admin/home/notices/class-sensei-home-notices.php 86.39% <100.00%> (+0.16%) ⬆️
includes/internal/emails/class-email-post-type.php 59.09% <100.00%> (+5.24%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbfe28...f13e2b6. Read the comment docs.

@aaronfc aaronfc marked this pull request as ready for review May 4, 2023 16:30
@aaronfc aaronfc requested a review from a team May 4, 2023 16:30
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aaronfc aaronfc merged commit 3ed9696 into trunk May 5, 2023
@aaronfc aaronfc deleted the feature/reengaging-customers branch May 5, 2023 05:52
@Imran92 Imran92 added this to the 4.14.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants