Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing link in Sensei plugin description. #6853

Merged
merged 1 commit into from
May 3, 2023

Conversation

anaemnesis
Copy link
Contributor

Proposed Changes

Ensures that:

Submit your course to Sensei LMS' public course showcase at https://senseilms.com/showcase/. Sensei LMS' course showcase allows you to reach new audiences to expand your course's visibility.

Links to https://senseilms.com/showcase/, whereas at present, it does not:

From https://wordpress.org/plugins/sensei-lms/:

Screenshot from 2023-05-02 15-24-36

Testing Instructions

  1. Download branch
  2. Validate markdown

This PR needs to be approved and merged here, and the changes copied over to the SVN repo for deployment there too, which I don't have access to.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@anaemnesis anaemnesis requested review from donnapep and a team May 2, 2023 14:26
@anaemnesis anaemnesis self-assigned this May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #6853 (9b0597b) into trunk (c5e4e58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #6853   +/-   ##
=========================================
  Coverage     47.37%   47.37%           
  Complexity    10124    10124           
=========================================
  Files           499      499           
  Lines         35995    35995           
  Branches        283      283           
=========================================
  Hits          17054    17054           
  Misses        18729    18729           
  Partials        212      212           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836e3e2...9b0597b. Read the comment docs.

Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this one can likely wait to be deployed with our next release.

@anaemnesis anaemnesis merged commit 76cf796 into trunk May 3, 2023
22 of 23 checks passed
@anaemnesis anaemnesis deleted the fix/missing-link-sensei-description branch May 3, 2023 07:29
@Imran92 Imran92 added this to the 4.14.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants