-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update font sizes for module title and lesson header #7068
Conversation
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #7068 +/- ##
=========================================
Coverage 51.93% 51.93%
Complexity 11277 11277
=========================================
Files 631 631
Lines 47710 47710
Branches 421 421
=========================================
Hits 24779 24779
Misses 22594 22594
Partials 337 337 Continue to review full report in Codecov by Sentry.
|
@Imran92 I'm not sure that this should be configurable via a block setting for a few reasons:
There are already some notes in the issue description where Andrei left some design feedback:
I added a consideration as well:
|
Another thought that may be better - We could obey the heading font sizes that are in the original designs. So the module ( If you like, we could move this one back to To Do given there are higher priority things now. 🙂 |
Good suggestion, I've updated them here d3e9c3a. I've used rem units for the font sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. However the conflict needs to be resolved.
And I'm not entirely sure why @donnapep asked to set default values in pixels — was there something behind that or em is also fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make the required action obvious: need to resolve conflicts.
Test the previous changes of this PR with WordPress Playground. |
Resolves Automattic/themes#7085
Proposed Changes
We've used the preset font sizes of course theme. We've used the medium font size for the module name and small font size for the lesson title.
For default variation of Course theme, we didn't change the font size as the medium of default was a bit smaller.
Testing Instructions
Screenshots:
Pre-Merge Checklist