-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module spacing when Learning Mode is not enabled #7272
Conversation
margin: 0; | ||
color: inherit; | ||
padding-top: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only adds this padding
. The rest of the changes are just sorting the properties to follow the Sensei standard.
Codecov Report
@@ Coverage Diff @@
## trunk #7272 +/- ##
=========================================
Coverage 50.59% 50.59%
Complexity 10975 10975
=========================================
Files 608 608
Lines 46286 46286
Branches 402 402
=========================================
Hits 23417 23417
Misses 22542 22542
Partials 327 327
Continue to review full report in Codecov by Sentry.
|
Makes sense to me. 👍 Following the idea of fixing it for other themes, what do you think of using |
Good idea! Updated here: 8e68ffa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Proposed Changes
It didn't happen with Learning Mode enabled because of this style:
sensei/assets/css/3rd-party/themes/course/learning-mode.scss
Line 213 in 96012db
I noticed it happening only with Course theme, but I decided to fix it directly in Sensei core because if it happened for other themes, it would also be fixed. Does it make sense?
Testing Instructions
Screenshots
Before:
After:
Pre-Merge Checklist