Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact teacher full width in learning mode #7288

Merged
merged 5 commits into from Nov 16, 2023

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Nov 14, 2023

Resolves the issue of the Contact teacher button becoming full width in learning mode in Divi and Astra

Proposed Changes

  • Fixed contact teacher button becoming full width in learning mode. It was probably a side effect of this change.

Testing Instructions

  1. Add a course with a lesson
  2. Add a contact teacher button in the lesson
  3. Make sure learning mode is on
  4. Enable Astra theme
  5. Access the lesson as student from frontend
  6. Make sure contact teacher button isn't full width.

Before

Screenshot 2023-11-14 at 2 36 19 PM

After

Screenshot 2023-11-14 at 2 36 33 PM

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@Imran92 Imran92 added this to the 4.19.2 milestone Nov 14, 2023
@Imran92 Imran92 requested a review from a team November 14, 2023 08:59
@Imran92 Imran92 self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #7288 (dc309f7) into trunk (a8021fd) will increase coverage by 0.03%.
Report is 53 commits behind head on trunk.
The diff coverage is 86.73%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7288      +/-   ##
============================================
+ Coverage     50.76%   50.79%   +0.03%     
- Complexity    11048    11049       +1     
============================================
  Files           611      611              
  Lines         46669    46703      +34     
  Branches        404      404              
============================================
+ Hits          23690    23724      +34     
  Misses        22652    22652              
  Partials        327      327              
Files Coverage Δ
...ludes/blocks/course-theme/class-lesson-actions.php 98.00% <100.00%> (ø)
includes/class-sensei-grading.php 10.87% <ø> (ø)
.../course-theme/class-sensei-course-theme-lesson.php 94.81% <100.00%> (ø)
includes/class-sensei-updates.php 43.44% <90.00%> (ø)
...ate-tasks/class-sensei-update-legacy-quiz-data.php 94.59% <94.59%> (ø)
includes/class-sensei-utils.php 52.22% <0.00%> (ø)
includes/class-sensei-quiz.php 69.31% <86.66%> (+1.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea99391...dc309f7. Read the comment docs.

m1r0
m1r0 previously approved these changes Nov 15, 2023
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button looks good. 👍

@Imran92 Imran92 merged commit 711d3f6 into trunk Nov 16, 2023
24 checks passed
@Imran92 Imran92 deleted the fix/contact-teacher-full-width-in-learning-mode branch November 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants