Scope CSS to Learning Mode templates only #7382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7226.
Proposed Changes
Some Learning Mode CSS is affecting non-Learning Mode templates. Given that it's not possible to conditionally load CSS for some templates but not for others, this PR scopes the CSS better. This problem was introduced by 997bbf8. Although I tried to reproduce, I didn't see any issue with Astra in the editor after reverting that change.
Having said that, I think an argument could be made as to whether we should be so opinionated about our CSS in the first place, especially for block themes. In the future, we may want to consider defaulting to the theme's fonts, colors etc., and just provide sensible defaults to classic themes (or maybe not even for classic themes either 🤷🏻♀️ ).
Testing Instructions
Pre-Merge Checklist