New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make customize template task point to Learning Mode template #7393
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #7393 +/- ##
=========================================
Coverage 50.94% 50.94%
- Complexity 11150 11153 +3
=========================================
Files 613 613
Lines 47063 47067 +4
Branches 404 404
=========================================
+ Hits 23976 23980 +4
Misses 22760 22760
Partials 327 327
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well, but I think we should also update the completion logic (Sensei_Admin::admin_init
) to mark it as completed only when visiting the lesson template.
…om/Automattic/sensei into add/update-customize-template-task
Thanks @renatho ! I've updated the code here 5d1bf9f . Now it will be marked as completed only when the user clicks the task. A side-effect of this will be that it'll no longer be marked as completed if the user visits the template in the site editor manually. But that's an edge case I think we can leave for now as there's not a reliable way ATM to detect if the user has visited the template in site editor or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Imran92!
Looks good and works well for me!
A side-effect of this will be that it'll no longer be marked as completed if the user visits the template in the site editor manually. But that's an edge case I think we can leave for now as there's not a reliable way ATM to detect if the user has visited the template in site editor or not.
And I think we can live with this side-effect!
@Imran92 It seems that we're taking the user to the site editor, but not actually opening the template in the editor. Can we make that change? The user shouldn't have to click the pencil icon to get there. We should make it as easy as possible for them. This should make the completion logic simpler too. |
Resolves #7376
Proposed Changes
Testing Instructions
Before
After
Pre-Merge Checklist