New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sensei pages on plugin activation without depending on onboarding completion #7426
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #7426 +/- ##
=========================================
Coverage 51.03% 51.04%
- Complexity 11165 11167 +2
=========================================
Files 613 614 +1
Lines 47137 47148 +11
Branches 405 405
=========================================
+ Hits 24058 24066 +8
- Misses 22752 22755 +3
Partials 327 327
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this! Works as described.
Resolves #7187
Proposed Changes
Previously we created the sensei pages only when the user completed the onboarding. If for some reason the user didn't complete the onboarding or skipped it, the pages didn't get created, resulting in the users not finding the Courses page, they My Courses page etc. So now we are changing the logic to create the pages on Activation of the plugin. I haven't removed it from the onboarding though because if the pages are already there, it already skips creating them, so if a user somehow deletes those pages or wants to recreate these pages for some reason, we can just tell them to go through the onboarding URL.
Testing Instructions
Pre-Merge Checklist