New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs links to the page settings #7488
Conversation
06c6f35
to
87efcb8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #7488 +/- ##
============================================
+ Coverage 51.26% 51.45% +0.18%
- Complexity 11189 11203 +14
============================================
Files 614 622 +8
Lines 47259 47408 +149
Branches 407 414 +7
============================================
+ Hits 24229 24394 +165
+ Misses 22703 22681 -22
- Partials 327 333 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Maybe we need to update the docs (or at least add a corresponding label). Currently, the docs say about the purpose of each page, but they don't say that we can't use the same page for everything. WDYT?
Thanks, Dmitry.
cc @jinnypark because she added the docs. |
@m1r0 and @merkushin - the doc is in progress, but I have limited time to continue updating them. I ran out of time, so it's kind of in a 'draft'. I won't have time until tomorrow at the earliest to do more updates, so feel free to update them! We can continue conversations about docs update to this issue: https://github.com/Automattic/jpop-satellite-docs/issues/193 |
Proposed Changes
To help users better understand how to use the page settings, this PR adds docs links to the settings description.
Context
p1708014451312029-slack-C02P7FHLVR9
Testing Instructions
Pre-Merge Checklist