Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Customize Colors" link for classic themes #7491

Merged
merged 3 commits into from Feb 22, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Feb 21, 2024

Proposed Changes

Remove Customize Colors link from Appearance settings for classic themes. This takes the user to the Customizer, but it doesn't really work. They can use the site editor to adjust colors instead.

Also updated https://senseilms.com/documentation/customizing-learning-mode-colors/ to remove references to the Customizer.

Testing Instructions

  1. Activate a classic theme.
  2. Go to Sensei LMS > Settings > Appearance.
  3. Ensure there is no Customize Colors link.

Screenshot 2024-02-21 at 1 13 23 PM

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.21.0 milestone Feb 21, 2024
@donnapep donnapep self-assigned this Feb 21, 2024
@donnapep donnapep requested a review from a team February 21, 2024 18:22
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (884ae10) 51.45% compared to head (8db1ea9) 51.50%.
Report is 2 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7491      +/-   ##
============================================
+ Coverage     51.45%   51.50%   +0.05%     
- Complexity    11203    11231      +28     
============================================
  Files           622      622              
  Lines         47408    47502      +94     
  Branches        414      414              
============================================
+ Hits          24394    24468      +74     
- Misses        22681    22701      +20     
  Partials        333      333              
Files Coverage Δ
includes/class-sensei-settings.php 60.88% <ø> (+0.61%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e332a28...8db1ea9. Read the comment docs.

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link's gone as expected 👍

@donnapep donnapep merged commit b1fa0e6 into trunk Feb 22, 2024
24 checks passed
@donnapep donnapep deleted the remove/customize-colors-link branch February 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants