Fix Sensei Email template being set as default template in editor when Gutenberg is installed #7517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7516
Proposed Changes
The latest GB sends an Ajax request to the server and fetches available templates. When we include the Sensei Email template using the
get_block_templates
filter, we check the Post Type, URL, template type, etc to make sure to only load this template for eithersensei_email
CPT or Site Editor (in which case, the current post type is null). But this ajax request was passing the Site Editor check because of its URL structure. To prevent it, we are returning early without adding Sensei Email to the list when it's a lookup request from the editor.Testing Instructions
PHP Warning: Undefined array key "single-sensei_email" in ........
Bonus: Try thinking about any scenario where it can have side effects and check if it does. LMK if you find any.
Pre-Merge Checklist