New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactivity to course steps #7535
Conversation
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #7535 +/- ##
============================================
- Coverage 51.92% 51.84% -0.09%
- Complexity 11265 11268 +3
============================================
Files 630 631 +1
Lines 47683 47817 +134
Branches 421 446 +25
============================================
+ Hits 24759 24790 +31
- Misses 22587 22668 +81
- Partials 337 359 +22
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test the previous changes of this PR with WordPress Playground. |
…utomattic/sensei into add/interaction-on-course-step
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, Imran! I added a few small suggestions. 😉
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tweaks @Imran92!
I just added a last comment: #7535 (comment). If it's something more complex than I'm thinking, maybe we could ignore it.
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Resolves #7446
Proposed Changes
I have added tests for the functions and components. For the interactivity, this looks like a candidate for e2e testing. Otherwise, it doesn't look like it's possible to test the interactions reliably.
I'll create an issue for writing the e2e tests.
Also, ATM if someone clicks on a pagination step, we can't show the interactivity because tour-kit sends a wrong index to the callback. We're creating a PR in tour-kit library to fix it.
Testing Instructions
sensei_tours
)Untitled.mov
Pre-Merge Checklist