Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Customize your lesson template" task #7539

Merged
merged 2 commits into from Mar 14, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Mar 14, 2024

Resolves #7508.

Proposed Changes

Removes the "Customize your lesson template" task from the task list.

Testing Instructions

  1. Enable the Course theme.
  2. Execute the following SQL - delete from wp_options where option_name like '%sensei_home_task_%.
  3. Go to Sensei LMS > Home.
  4. Check that there is no "Customize your lesson template" in the task list.
  5. Ensure the progress is calculated correctly.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.22.0 milestone Mar 14, 2024
@donnapep donnapep self-assigned this Mar 14, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (83e8eda) to head (8450ab6).
Report is 1 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7539      +/-   ##
============================================
- Coverage     51.93%   51.92%   -0.02%     
+ Complexity    11277    11265      -12     
============================================
  Files           631      630       -1     
  Lines         47710    47683      -27     
  Branches        421      421              
============================================
- Hits          24779    24759      -20     
+ Misses        22594    22587       -7     
  Partials        337      337              
Files Coverage Δ
...in/home/tasks/class-sensei-home-tasks-provider.php 83.14% <ø> (-0.38%) ⬇️
includes/class-sensei-admin.php 12.11% <ø> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b641fc...8450ab6. Read the comment docs.

@donnapep donnapep merged commit ddc175e into trunk Mar 14, 2024
25 of 26 checks passed
@donnapep donnapep deleted the update/remove-customize-lesson-template-task branch March 14, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Customize Lesson Template" task
1 participant