Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opinionated CSS class from login form #7542

Merged
merged 2 commits into from Mar 21, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Mar 15, 2024

Resolves https://wordpress.org/support/topic/class-alignwide-is-hardcoded-in-output-of-my-courses-content/.

Proposed Changes

We shouldn't be using the alignwide class on the login form. Ideally, the login form should be the same width as the rest of the site's content.

Testing Instructions

  1. Navigate to the My Courses page as a logged out user.
  2. Check that the login form is the same width as page / post content.
  3. Test on different themes.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.22.0 milestone Mar 15, 2024
@donnapep donnapep self-assigned this Mar 15, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (46c9479) to head (3be3259).
Report is 38 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7542      +/-   ##
============================================
- Coverage     51.92%   51.82%   -0.10%     
- Complexity    11265    11307      +42     
============================================
  Files           630      640      +10     
  Lines         47683    47979     +296     
  Branches        421      446      +25     
============================================
+ Hits          24759    24865     +106     
- Misses        22587    22755     +168     
- Partials        337      359      +22     
Files Coverage Δ
includes/class-sensei-frontend.php 17.76% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548e120...3be3259. Read the comment docs.

@donnapep donnapep marked this pull request as draft March 18, 2024 11:56
@donnapep donnapep modified the milestones: 4.22.0, 4.23.0 Mar 20, 2024
@donnapep donnapep marked this pull request as ready for review March 21, 2024 19:27
@donnapep donnapep merged commit 49e6c59 into trunk Mar 21, 2024
26 checks passed
@donnapep donnapep deleted the remove/opinionated-block-editor-class branch March 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant