Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensei pro upsell task in home #7562

Merged
merged 30 commits into from Mar 29, 2024
Merged

Add sensei pro upsell task in home #7562

merged 30 commits into from Mar 29, 2024

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Mar 26, 2024

Resolves #7486

Proposed Changes

Added a task in Sensei Home for taking users to senseilms.com upsell page when they have woo activated but Sensei pro is not installed.

Testing Instructions

  1. Create a new site with Sensei installed, don't install WooCommerce or Sensei Pro yet
  2. Go to Sensei Home and make sure you don't see "Sell your course with Sensei Pro" (because Woo not installed)
  3. Now install Woo But don't activate
  4. Still shouldn't see the task
  5. Activate Woo
  6. Should see the task now, but don't click just yet
  7. Install Senesi Pro
  8. Shouldn't see the task now
  9. Deactivate Sensei Pro, but don't delete
  10. Still shouldn't see the task (because we don't want to upsell Pro if you have it already installed, doesn't matter if it's activated or not)
  11. Now delete Sensei Pro and install a WCPC build
  12. Shouldn't see the task
  13. Remove WCPC
  14. Task should appear again
  15. Click on the task, you should be taken to Sensei Pro upsell page
  16. Check in tracks for sensei_home_task_complete event after giving it some time to update
  17. Go to Sensei Home page again, refresh it if needed
  18. Make sure the task is crossed now
  19. Install Sensei Pro again
  20. Make sure the Crossed task is removed
Screenshot 2024-03-26 at 11 02 23 PM

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

github-actions bot commented Mar 26, 2024

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit fc5fa71 and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
home/index.js 21.2 kB +65 B ( +0.31% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 65.30612% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 51.78%. Comparing base (8c91c63) to head (fc5fa71).
Report is 8 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7562   +/-   ##
=========================================
  Coverage     51.77%   51.78%           
- Complexity    11307    11323   +16     
=========================================
  Files           640      641    +1     
  Lines         48116    48164   +48     
  Branches        467      468    +1     
=========================================
+ Hits          24912    24941   +29     
- Misses        22826    22844   +18     
- Partials        378      379    +1     
Files Coverage Δ
includes/class-sensei-data-cleaner.php 87.75% <ø> (ø)
...rest-api/class-sensei-rest-api-home-controller.php 97.26% <100.00%> (+0.70%) ⬆️
assets/home/tasks-section/task-item.js 40.00% <0.00%> (-20.00%) ⬇️
includes/admin/class-sensei-home.php 14.28% <66.66%> (ø)
...in/home/tasks/class-sensei-home-tasks-provider.php 82.41% <50.00%> (-0.73%) ⬇️
...e/tasks/task/class-sensei-home-task-pro-upsell.php 46.15% <46.15%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5a7d8...fc5fa71. Read the comment docs.

Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 added this to the 4.23.0 milestone Mar 26, 2024
@Imran92 Imran92 self-assigned this Mar 26, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 closed this Mar 26, 2024
@Imran92 Imran92 reopened this Mar 26, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 requested a review from a team March 26, 2024 18:09
@Imran92 Imran92 marked this pull request as ready for review March 26, 2024 18:09
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 requested a review from renatho March 28, 2024 17:49
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and works well!

@Imran92 Imran92 merged commit f6a7655 into trunk Mar 29, 2024
25 checks passed
@Imran92 Imran92 deleted the add/sensei-pro-upsell-task branch March 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upsell task to install Sensei-pro in Sensei home checklist for Course sell
2 participants