Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests #7578

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix E2E tests #7578

merged 1 commit into from
Apr 4, 2024

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Apr 4, 2024

Proposed Changes

  • Fix E2E tests. The selector to preview the course didn't exist. I tested it with WP 6.4, and I couldn't see it there either. I couldn't identify the origin of the issue, but fixing the selector fixed it.

Testing Instructions

Check that CI is passing.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (0761ee1) to head (01d7b5f).
Report is 1 commits behind head on trunk.

❗ Current head 01d7b5f differs from pull request most recent head 201e6e9. Consider uploading reports for the commit 201e6e9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7578   +/-   ##
=========================================
  Coverage     51.76%   51.76%           
  Complexity    11321    11321           
=========================================
  Files           641      641           
  Lines         48181    48181           
  Branches        470      470           
=========================================
  Hits          24940    24940           
  Misses        22860    22860           
  Partials        381      381           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34ea67...201e6e9. Read the comment docs.

Copy link

github-actions bot commented Apr 4, 2024

Test the previous changes of this PR with WordPress Playground.

@renatho renatho self-assigned this Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

Test the previous changes of this PR with WordPress Playground.

@renatho renatho added this to the 4.23.0 milestone Apr 4, 2024
@renatho renatho requested a review from a team April 4, 2024 14:23
@renatho renatho marked this pull request as ready for review April 4, 2024 14:23
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renatho renatho merged commit fea167f into trunk Apr 4, 2024
38 of 48 checks passed
@renatho renatho deleted the fix/e2e-test branch April 4, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants