Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draft lessons getting published when Course is updated #7582

Merged
merged 15 commits into from Apr 11, 2024
Merged

Fix draft lessons getting published when Course is updated #7582

merged 15 commits into from Apr 11, 2024

Commits on Apr 5, 2024

  1. Move outsite is admin 

    Because for the actual publish call sent by default by Gutenberg, is_admin is false. So it will never catch the actual publish call
    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    da19d8a View commit details
    Browse the repository at this point in the history

  2. Publish lessons only on course publish, not update

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d5fde01 View commit details
    Browse the repository at this point in the history

  3. Explain why we return when we detect it's just update call

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ab99b76 View commit details
    Browse the repository at this point in the history

  4. Explain why we reset the flag

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e42968d View commit details
    Browse the repository at this point in the history

  5. Add changelog

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    18e51d0 View commit details
    Browse the repository at this point in the history

  6. Fix old tests

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    25997be View commit details
    Browse the repository at this point in the history

  7. Test that we don't publish draft lessons during course update

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    75cf1ca View commit details
    Browse the repository at this point in the history

  8. Test that publishing course not publishing lesson when meta false

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    397a263 View commit details
    Browse the repository at this point in the history

  9. Test that flag is set during publish

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0cbd25b View commit details
    Browse the repository at this point in the history

  10. Test that lesson get published in subsequent immediate call

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bd304e9 View commit details
    Browse the repository at this point in the history

  11. Add test that for more subsequent calls, it doesn't publish

    @Imran92
    Imran92 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    45c7eb2 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add check for metabox save call

    @Imran92
    Imran92 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8eda32e View commit details
    Browse the repository at this point in the history

  2. Add test for metabox save call

    @Imran92
    Imran92 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    cba86c2 View commit details
    Browse the repository at this point in the history

  3. Add comments to tests

    @Imran92
    Imran92 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    137a105 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Add comments explaining course saving process

    @Imran92
    Imran92 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2ac96e8 View commit details
    Browse the repository at this point in the history