Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the default implementation for getExtractedText #1591

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Use the default implementation for getExtractedText #1591

merged 3 commits into from
Apr 4, 2023

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Apr 4, 2023 •
edited

Fixes #1590.

Fix

Users using Samsung devices with Android 13 are experiencing text duplication.

Test

Note: Please test on a Samsung device with Android 13.

  1. Create a new note
  2. Type Hello 2.22. In the current version, the editor duplicates the version and adds Hello. 2.22.2.
  3. Check steps in issue Text duplicating after updating the app to 2.26 #1590 and verify that the problem is fixed.
  4. Check steps in issue Checkboxes disappearing in notes for Samsung Galaxy users on upgrade to OneUI 5/ Android 13 #1582 and verify that the problem is fixed.
  5. Check steps in issue Long lists jump to the bottom when making changes #1580 and verify that the problem is fixed.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in 70f1550 with:

Fixed problem with editor in Samsung devices where users observed text duplication.

@danilo04
Use the default implementation for getExtractedText
42ca1bc 
We copied the implementation of EditableInputConnection for
getExtractedText. We found that for some grammarly suggestions, the
current implementation was duplicating content.
@danilo04
Add release notes
f299231
@danilo04
Add release notes
70f1550
@danilo04 danilo04 requested a review from khaykov April 4, 2023 19:19
@danilo04 danilo04 added [Type] Bug Something isn't working. Samsung labels Apr 4, 2023
@danilo04 danilo04 marked this pull request as ready for review April 4, 2023 19:20
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 4, 2023 •
edited

You can test the changes on this Pull Request by downloading an installable build (simplenote-android-installable-build-pr1591-70f1550-01874db4-e714-4e29-82cb-625cc5ccc536.apk), or scanning this QR code:

@khaykov
Copy link
Member

khaykov commented Apr 4, 2023

Good news - issues is definitely happens less.

Bad news it still happens if some parts of the text were "flagged" by Grammarly for correction.

Screen_Recording_20230404_155654_Simplenote.mp4

khaykov
khaykov approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disregard my previous comment, I compiled a stale code, and had issues because of that. From what I can tell, the fix works well for Simplenote 👍

@khaykov khaykov merged commit 4f46724 into trunk Apr 4, 2023
@khaykov khaykov deleted the issue/1590-fix-samsung-text-dup branch April 4, 2023 23:04
@mokagio mokagio added this to the 2.27 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaykov khaykov khaykov approved these changes

Assignees
No one assigned
Labels
Samsung [Type] Bug Something isn't working.
Projects
None yet
Milestone
2.27
Development

Successfully merging this pull request may close these issues.

Text duplicating after updating the app to 2.26
4 participants
@danilo04 @wpmobilebot @khaykov @mokagio