Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a catch for billing exception on samsung devices. #1601

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Aug 2, 2023

Fixes #1600

It's a pretty weird issue, that only happens on Samsung devices, mostly on API 13. I was not able to reproduce it, but I found a similar issue reported here.

For now the fix is to just add an exception handling to the billing call.

There is no testing instructions, just make sure app builds and runs.

@khaykov khaykov added the crash Bad stuff — something related to an app crash! label Aug 2, 2023
@khaykov khaykov requested a review from danilo04 August 2, 2023 17:47
Copy link
Contributor

@danilo04 danilo04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khaykov, I tested the changes and the billing client is working as expected.

@danilo04 danilo04 merged commit 1cfe5c5 into trunk Aug 4, 2023
8 checks passed
@danilo04 danilo04 deleted the issue/catch-bind-requests-excpetion-on-samsung branch August 4, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Bad stuff — something related to an app crash!
Projects
None yet
2 participants