Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bottom Sheet #933

Merged
merged 5 commits into from
Feb 6, 2020
Merged

Update Bottom Sheet #933

merged 5 commits into from
Feb 6, 2020

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Feb 5, 2020

Fix

All bottom sheet dialogs hide the navigation bar buttons on large screen devices (e.g. tablets).
These changes update the view to which the custom layout parameters are applied in the bottom sheet base class. Consequently, the peek height must be updated and the collapsed state must be disabled in all inherited classes. These changes include the updates in Simperium from Simperium/simperium-android#218 associated with the authentication screen. See the screenshots below for illustration.

update_bottom_sheet_login_portrait

update_bottom_sheet_login_landscape

update_bottom_sheet_history_portrait

update_bottom_sheet_history_landscape

update_bottom_sheet_share_portrait

update_bottom_sheet_share_landscape

update_bottom_sheet_info_portrait

update_bottom_sheet_info_landscape

Note

This pull request does not include the changes to the Information bottom sheet from #932. Those changes are in another branch.

Test

  1. Clear app data.
  2. Tap Log In button.
  3. Notice navigation bar buttons are visible.
  4. Log in with preferred method.
  5. Tap any note in list.
  6. Tap History action in app bar.
  7. Notice navigation bar buttons are visible.
  8. Dismiss History bottom sheet.
  9. Tap Share action in app bar.
  10. Notice navigation bar buttons are visible.
  11. Dismiss Share bottom sheet.
  12. Tap Info action in app bar.
  13. Notice navigation bar buttons are visible.
  14. Dismiss Info bottom sheet.

Review

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@peril-automattic
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@anitaa1990 anitaa1990 self-assigned this Feb 6, 2020
Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: Will wait for design review to complete before merging 👍

@SylvesterWilmott
Copy link

Looks good @theck13 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants