Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Match position indicator does not update when matches number changes #2809

Open
pachlava opened this issue Mar 24, 2021 · 0 comments · May be fixed by #2846
Open

[Search] Match position indicator does not update when matches number changes #2809

pachlava opened this issue Mar 24, 2021 · 0 comments · May be fixed by #2846
Labels
bug Something isn't working [feature] search Anything related to searching.

Comments

@pachlava
Copy link
Contributor

Expected

If the note is edited while search mode is active, the position indicator (2 of 5 thing) should update the current position digit, if matches number changes.

Observed

Current position indicator never changes regardless of matches number:

Screen.Recording.2021-03-24.at.16.46.07.mov

Reproduced

  1. Have a note with multiple instances of word in it
  2. Search for word
  3. Move the current match position in a note with > button or with Ctrl/Cmd+G, so that it becomes greater than one (e.g. 5 of 5)
  4. Start removing the instances of word until one remains ~> the indicator will show 5 of 1

Where did you see the bug

For example in

  • System Make: Parallels Desktop on MBP 16"
  • OS: Windows
  • OS version: 10 Home 20H2 build 19042.508
  • Simplenote app version: 2.9.0-beta1 desktop
@pachlava pachlava added bug Something isn't working [feature] search Anything related to searching. labels Mar 24, 2021
@sandymcfadden sandymcfadden linked a pull request Apr 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [feature] search Anything related to searching.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant