Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Too Many Login Attempts alert header contains no Many word. #1475

Merged
merged 1 commit into from Dec 8, 2021

Conversation

dbarros
Copy link
Contributor

@dbarros dbarros commented Dec 3, 2021

Fixed a minor grammatical error where the UI would show "Too Login Attempts", instead of "Too Many Login Attempts". #1462

Fix

When too many login attempts were made by the user, the alert shown to the user had the title: "Too Login Attempts". It is not grammatically correct: "Too Many Login Attempts"

All instances of "Too Login Attempts" in the code were also corrected (this included all localization files).

Test

(Required) List the steps to test the behavior. For example:

  1. Go to the Login screen
  2. Attempt to login with an incorrect password
  3. Continue trying step 2 until you see the alert message, which will now be titled with "Too Many Login Attempts"

Review

(Required) Add instructions for reviewers.
Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required)

These changes do not require release notes.

Fixed a minor grammatical error where the UI would show "Too Login Attempts", instead of "Too Many Login Attempts". Automattic#1462
@peril-automattic
Copy link

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping us improve Simplenote @dbarros!

:shipit:

@peril-automattic
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-automattic
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jleandroperez jleandroperez merged commit b64721a into Automattic:develop Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants