Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainer: Purchase Restoration #1498

Merged
merged 3 commits into from Nov 14, 2022

Conversation

jleandroperez
Copy link
Contributor

Details

In this PR we're implementing manual purchase restoration. Not really needed, but required by guidelines.

#1491

Test: Not Found

  1. Fresh install Simplenote
  2. Log into your account
  3. Open Settings > Restore Purchases
  • Verify you get an alert indicating that no previous purchases were found

Test: Restored

  1. Fresh install Simplenote
  2. Log into your account
  3. Open the sidebar and click on the Sustainer UI
  4. Follow thru the IAP flow. Once you get the final alert (You're all set) DO NOT click OK
  5. Stop execution
  6. Comment L82 and L83 from StoreManager
  7. Relaunch Simplenote
  8. Open Settings and press over Restore purchases
  • Verify you get your Sustainer status restored

Test: Already Sustainer

  1. Fresh install Simplenote
  2. Log into your account
  3. Become a Sustainer
  4. Open Settings and tap over Restore Purchases
  • Verify that you get an alert indicating that you're already a sustainer

Release

These changes do not require release notes.

@jleandroperez jleandroperez added this to the 4.48 ❄️ milestone Nov 14, 2022
@jleandroperez jleandroperez self-assigned this Nov 14, 2022
@objc
func restorePurchases() {
guard #available(iOS 15.0, *) else {
presentPurchasesRestored(alert: .unsupported)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suboptimal, yet, somehow gracefully handling this flow.

Refactoring SPSettingsViewController is out of the question, at the moment!

@jleandroperez jleandroperez marked this pull request as ready for review November 14, 2022 18:02
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1498-6b2045c-0184774b-b54f-41d7-b468-1f57631a4e78 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jleandroperez
Copy link
Contributor Author

jleandroperez commented Nov 14, 2022

@spencertransier sir, would it be possible to submit a new build for review? this should get the latest rejection.

Not sure if we do have a way to tell the reviewers, but just in case... purchases can now be restored from:

Sidebar > Settings > Restore Purchases

Thank you @bjhomer + @spencertransier !!!

@jleandroperez jleandroperez merged commit b53c4f6 into release/4.48 Nov 14, 2022
@jleandroperez jleandroperez deleted the lantean/1491-restore-purchases branch November 14, 2022 18:25
@spencertransier
Copy link
Contributor

@jleandroperez Will do! I'll get a new build going now. I'll respond to the rejection with the instructions for how to find the "Restore Purchases" button when I submit the new build. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants