Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIAlertController+Sustainer: Switching to Alert #1501

Merged
merged 2 commits into from
Nov 15, 2022
Merged

UIAlertController+Sustainer: Switching to Alert #1501

merged 2 commits into from
Nov 15, 2022

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Nov 15, 2022 •
edited by frosty
Loading

Fix

In this PR we're fixing an iPad crasher, triggered after pressing the Sustainer banner.

Closes #1499

Test

  1. Launch Simplenote on an iPad device
  2. Open the Sidebar
  3. Tap the Sustainer button
  • Verify the app doesn't crash

Release

These changes do not require release notes.

@jleandroperez jleandroperez self-assigned this Nov 15, 2022
@jleandroperez jleandroperez marked this pull request as ready for review November 15, 2022 14:20
@jleandroperez jleandroperez added the crash Bad stuff — something related to an app crash! label Nov 15, 2022
@spencertransier spencertransier added this to the 4.48 ❄️ milestone Nov 15, 2022
frosty
frosty approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I wonder if we'd want to ideally do sheet on a compact width view (like phone), and alert otherwise?

@jleandroperez
Copy link
Contributor Author

Thank you sir!! (Also: feedback addressed, looks better indeed!!)

@jleandroperez jleandroperez merged commit 87c33f4 into release/4.48 Nov 15, 2022
@jleandroperez jleandroperez deleted the lantean/1499-ipad-crash branch November 15, 2022 21:34
@jleandroperez
Copy link
Contributor Author

cc @spencertransier SORRY!!! me again!! 😂

Sir, would it be possible to submit yet another build for review?. Thanks in advance!!

@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1501-8802f0f-01847d36-a235-4e47-b8ae-88158c5e9492 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@spencertransier
Copy link
Contributor

@jleandroperez Yessir! I'll get on that 👍

@jleandroperez
Copy link
Contributor Author

Thank youuuuuu!!

@spencertransier spencertransier mentioned this pull request Nov 15, 2022
Merged
@jleandroperez jleandroperez mentioned this pull request Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosty frosty frosty approved these changes

Assignees

@jleandroperez jleandroperez

Labels
crash Bad stuff — something related to an app crash!
Projects
None yet
Milestone
4.48
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jleandroperez @wpmobilebot @spencertransier @frosty