Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default link data detector #248

Merged
merged 1 commit into from Nov 20, 2018
Merged

Restore default link data detector #248

merged 1 commit into from Nov 20, 2018

Conversation

roundhill
Copy link
Contributor

@roundhill roundhill commented Nov 19, 2018

About 4 years ago, we rolled our own linkifier in order to address a performance issue when loading a note with a large amount of links in it.

I've tested the default linkifier here in the future and have not observed any noticeable slowdowns when loading a note that contains hundreds of links, even on an older iPad mini. So I think we're safe to restore the default behavior.

To Test

  • Create a whopper of a note that contains lots of text and links. I used this, pasted a few times over: https://moz.com/top500
  • Load the note in the editor, you should see the links become blue.
  • Tapping inside of the note text will disable the links when the soft keyboard shows.

Fixes #246

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely nothing cooler than deleting code!!!

:shipit:

@roundhill roundhill merged commit c943863 into develop Nov 20, 2018
@roundhill roundhill deleted the fix/linkifier branch November 20, 2018 22:44
@jleandroperez jleandroperez mentioned this pull request Jan 31, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants