New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WooCommerce icon #63
Conversation
LGTM |
Should have noted - the corner radii are from the original logo - scaled down. They're pretty close to lining up perfectly with our grid. Curious if there's any benefit to making this small tweak? |
I'd check the pixel preview. If it makes it sharper, I'd tweak. :) |
Radii now matches the soclal-logos grid.
Is that at the default 24px? Can we maybe tweak it slightly so the edges are all sharp at that size? :) |
The edges on the left icon are much fuzzier. |
That looks good. |
That's fixable but means breaking the grid; Edit: That's pretty funny. I moved the bottom-most points of the bubble a little to fix that preview blurring issue. I just pasted the updated version into the template to see how far "off-grid" that change made things... I'm beginning to question the reliability of the pixel preview :p |
Hah! Looking good :) |
Cheers. If you wouldn't mind approving @folletto I'll go ahead and merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :D
Based on the woocommerce.com Favicon, using the bubble from the WC logo.