use @einaros ws module instead of the old crap one #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3rd-Eden Thanks for this patch, spent 4 hours trying to figure out why the server in node.js and the client in node.js kept disconnecting. Hope this gets patched into socket.io-client very soon. I have tested this with my setup and it is now at last working - https://github.com/parj/glucose @guille Could I kindly request this pull is merged into Socket.IO? |
rauchg
added a commit
that referenced
this pull request
Jan 10, 2012
use @einaros ws module instead of the old crap one
|
Very cool! Thanks |
|
Thanks this was very useful . I was breaking my head over why the disconnect happenned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use @einaros ws module instead of the old crap one
(h) double highlight, pull request title sums it nicely