Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop jetifier #717

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Drop jetifier #717

merged 4 commits into from
Dec 21, 2021

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Dec 10, 2021

This PR is part of an effort of dropping Jetifier from WPAndroid.

Changes

  • Updates EventBus to v3.3.1 which is migrated to AndroidX - v3.3.1 is already being used in WPAndroid so it's technically tested already
  • Updates Utils to the latest version which is migrated to AndroidX
  • Disables Jetifier in example gradle properties

To Test:
Make sure to disable Jetifier in your local gradle.properties => Smoke test the example app

@peril-automattic
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@malinajirka malinajirka marked this pull request as ready for review December 10, 2021 13:43
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a blocker for wordpress-mobile/WordPress-Android#15675, I figured I'd review this. The PR only contains version changes with utils being the only major-ish update. I think we are safe to merge this.

@oguzkocer oguzkocer merged commit 93695b4 into develop Dec 21, 2021
@oguzkocer oguzkocer deleted the drop-jetifier branch December 21, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants