Update Assistant-related icons #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
approved these changes
Jun 5, 2024
src/components/ai-input.tsx
Outdated
| </div> | ||
| ) } | ||
| <div className="flex items-end p-2"> | ||
| <div className="flex items-end py-2"> |
There was a problem hiding this comment.
The horizontal padding removal creates collision between the input and button focus styles, I feel space between the elements is beneficial. I wonder if we might retain the padding or address this in a different manner. WDYT?
Semi-related: I note the focus style color is different between these two elements.
There was a problem hiding this comment.
Good catch. I transferred the button spacing to the margin to preserve the unfocused layout styles, and updated the AIInput focus color to match the Button focus color (and the rest of Studio's input components). 👍
aiinput-border.mov
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves Assistant-related icons to match designs.
Proposed Changes
<ReturnIcon />and<MenuIcon />in favor of@wordpress/icons:keyboardReturnandmoreVertical.<AssistantIcon />to regular function component (#)Testing Instructions
STUDIO_AI=true npm start<AIInput />componentAssistant,keyboardReturn, andmoreVertical):Pre-merge Checklist