Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show scrollbars in tab panels when content overflows #255

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

fluiddot
Copy link
Contributor

Related to #225 (comment).

Proposed Changes

  • Override tab panel styles to customize the scrollbar. This is the same approach we used for the sidebar but using different colors.
show-scrollbars.mp4

Testing Instructions

  • Open the app.
  • Resize the window to the minimum size.
  • Navigate to the Settings tab.
  • Observe the content overflows.
  • Observe the scrollbar is always displayed.
  • Observe the content can be scrolled.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fluiddot fluiddot requested review from a team June 17, 2024 09:59
@fluiddot fluiddot self-assigned this Jun 17, 2024
@fluiddot fluiddot requested a review from matt-west June 17, 2024 10:00
@fluiddot
Copy link
Contributor Author

@matt-west For the scrollbar color, I've used the same one the macOS was showing. For the hover state, I simply made the color 20% darker. Let me know if you'd like to adjust the colors before merging. Thanks 🙇 !

Copy link
Contributor

@matt-west matt-west left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @fluiddot!

@fluiddot fluiddot changed the title Always show scrollbars in tab panels when content overdlows Always show scrollbars in tab panels when content overflows Jun 17, 2024
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fluiddot, the code change looks clear, and it works as expected. Now it's clearer for a user that the Settings panel can be scrolled down.

@wojtekn wojtekn merged commit b4613c3 into trunk Jun 17, 2024
12 checks passed
@wojtekn wojtekn deleted the fix/show-scrollbar-settings-tab branch June 17, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants