Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Clicking the user avatar in settings should got to their WP.com profile #5

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

katinthehatsite
Copy link
Contributor

Closes https://github.com/Automattic/dotcom-forge/issues/6641

Proposed Changes

This PR adds a link to Gravatar image in the settings modal that brings the user to their WordPress.com account.

Testing Instructions

  • Pull the changes from this branch locally
  • Start the app with nvm use && npm install && npm start
  • Click on the Gravatar image in the right sidebar to open the Settings modal
  • Click on the Gravatar icon in the modal
  • Confirm that you are brought to your WordPress.com account https://wordpress.com/me

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Apr 22, 2024
@katinthehatsite katinthehatsite added the [Type] Enhancement Improvement upon an existing feature label Apr 22, 2024
@katinthehatsite katinthehatsite changed the title Local Environment: Clicking the user avatar in settings should got to their WP.com profile Studio: Clicking the user avatar in settings should got to their WP.com profile Apr 22, 2024
@derekblank derekblank self-requested a review April 23, 2024 00:00
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to verify that clicking the Gravatar button opened https://wordpress.com/me successfully.

Copy link
Contributor

@kozer kozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and works as expected!

However, when the button is in :focus or :focus-visible state, the following outline appears.

2024-04-23T08:06:46,952399526+03:00
2024-04-23T08:07:19,375863452+03:00

Also note that the cursor pointer is also displayed if you are not directly on the image ( due to button padding ).

This is not a big deal, but maybe we want to improve that by removing padding/margin and outline on focus.

@katinthehatsite
Copy link
Contributor Author

Hi @kozer - I think it is because I am using the <Button> component that is wrapping the Gravatar and it seems that this is what it comes with in terms of accessibility. I will check a bit further 👀

@katinthehatsite
Copy link
Contributor Author

@kozer I have removed the padding at the bottom/top and left/right but left the outline for the accessibility (this is what we already have in the sidebar implementation of Gravatar as well - example below):

Screenshot 2024-04-23 at 8 42 10 AM

What do you think?

@kozer
Copy link
Contributor

kozer commented Apr 23, 2024

@kozer I have removed the padding at the bottom/top and left/right but left the outline for the accessibility (this is what we already have in the sidebar implementation of Gravatar as well - example below):

Screenshot 2024-04-23 at 8 42 10 AM What do you think?

Yes, that's great Kat! Thanks!

@katinthehatsite katinthehatsite merged commit c4eb019 into trunk Apr 23, 2024
5 checks passed
@katinthehatsite katinthehatsite deleted the add/link-to-gravatar-image branch April 23, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improvement upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants