Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <code> wrapper #163

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Remove <code> wrapper #163

merged 1 commit into from
Sep 17, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Sep 8, 2020

Fixes #162

Changes proposed

  • Remove the extra <code> tag inside the <pre> wrapper as it introduces backward compatiblility issues

Testing instructions

  • Create a post with a Syntaxhighlighter block on version 3.5.5 with any content
  • Update to this branch
  • Open the post frontend without saving the post again
  • Make sure the block is rendered correctly (without the extra <pre class.. before and after)

@yscik yscik added this to the v3.5.6 milestone Sep 8, 2020
alexsanford
alexsanford approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested, and it seems to work for me! 🚀

@yscik yscik merged commit f3d76f1 into master Sep 17, 2020
@yscik yscik deleted the fix/output-wrapper branch September 17, 2020 21:37
This was referenced Nov 13, 2020
Closed
Merged
@alexsanford alexsanford modified the milestones: v3.5.6, v3.6.0 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Breaking change after 3.5.5 - new output text introduced
2 participants
@yscik @alexsanford