Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tab size from plugin settings in block editor #174

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Use tab size from plugin settings in block editor #174

merged 1 commit into from
Dec 17, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 17, 2020 •
edited

Depends on #171

Changes proposed in this Pull Request

  • Respect tab size settings in the editor

Testing instructions

  • Set the Tab size option to a value of not 8 in Plugins > Syntaxhighlighter Evolved > Settings
  • Edit a post, add code block, insert code with tabs
  • Observe tab is not 8 spaces wide but respects the setting

@yscik yscik requested a review from jom November 17, 2020 00:09
@yscik yscik changed the base branch from master to add/toolbar-language November 17, 2020 00:09
@yscik yscik changed the base branch from add/toolbar-language to change/refactor-block November 17, 2020 00:10
@yscik yscik changed the base branch from change/refactor-block to add/toolbar-language November 17, 2020 00:10
@yscik yscik added this to the v3.6.0 milestone Nov 17, 2020
@yscik yscik changed the base branch from add/toolbar-language to change/refactor-block November 17, 2020 15:55
jom
jom approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well!

Base automatically changed from change/refactor-block to master December 17, 2020 15:56
@yscik yscik merged commit e149228 into master Dec 17, 2020
@yscik yscik deleted the fix/editor-tab-size branch December 17, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yscik @jom