Ensure HTML special characters don't get double-encoded #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e encoded and output by the render callback I believe this will address the issues described in #108 and #159. At first I thought I would just add `$code = str_replace( '>', '>', $code );` as a third line of "Undo escaping...", but then I figured it would potentially catch more edge cases to just decode all HTML entities at this point in the code. They get re-encoded later in the `shortcode_callback` method, so this helps further prevent double-encoding.
coreymckrill
added a commit
to WordPress/Learn
that referenced
this pull request
Dec 4, 2020
…#162) In some cases the `>` is getting double encoded. In lesson plans, for example, this is causing all code snippets to have `>` instead of `>`. This simply undoes the double-encoding. Ideally this can get fixed upstream. See Automattic/syntaxhighlighter#182 Fixes #158
|
I think you should also add a syntaxhighlighter/syntaxhighlighter.php Line 1166 in fbd9962 Hope this gets merged. |
|
Thanks for the PR! Resolved the conflicts and included this in #187, should be out in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will address the issues described in #108 and #159. At first I thought I would just add
$code = str_replace( '>', '>', $code );...as a third line under "Undo escaping...", but then I figured it would potentially catch more edge cases to just decode all HTML entities at this point in the code. Entities get re-encoded later in the
shortcode_callbackmethod, so this helps further prevent double-encoding.