Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MatLab brush key in brush map #188

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Fix MatLab brush key in brush map #188

merged 1 commit into from
Feb 8, 2021

Conversation

jom
Copy link
Member

@jom jom commented Jan 28, 2021

Fixes Automattic/wp-calypso#38788

Changes proposed in this Pull Request

  • This array has some ambiguity in its uses throughout the plugin. Sometimes the language check is isset( $this->brushes[$lang] ) and sometimes it is in_array( $lang, $this->brushes, true ). In addition, I think the block actually uses the brush names and not language names for its language selector.
  • All other languages have a key entry for every value entry. I did the same with MatLab to fix the issue.

Testing instructions

  • See issue.

@jom jom requested a review from alexsanford January 28, 2021 10:16
@jom jom self-assigned this Jan 28, 2021
@jom jom mentioned this pull request Jan 28, 2021
Closed
alexsanford
alexsanford approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 🚀

@jom jom merged commit 0c1010b into master Feb 8, 2021
@jom jom deleted the fix/matlab branch February 8, 2021 19:02
@jom jom added this to the v3.5.6 milestone Feb 10, 2021
@alexsanford alexsanford modified the milestones: v3.5.6, v3.6.0 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford approved these changes

Assignees

@jom jom

Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Syntax Highlighter Block: Cannot format MATLAB code.
2 participants
@jom @alexsanford