Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpcs #204

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Fix phpcs #204

merged 5 commits into from
Mar 10, 2021

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Mar 10, 2021

Changes proposed in this Pull Request

  • Fix some phpcs issues.

Testing instructions

  • Make sure the dist/blocks.editor.build.css is now loaded with the correct query string to avoid cache after the changes. It's the file change time when in debug mode, or the plugin version in the prod mode.
  • Make sure the Settings page (wp-admin > Settings -> SyntaxHIghlighter) still renders properly.

@renatho renatho added the [Type] Maintenance Changes to non-production files label Mar 10, 2021
@renatho renatho added this to the v3.6.0 milestone Mar 10, 2021
@renatho renatho self-assigned this Mar 10, 2021
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just noticed that the translators: comments are in the wrong place. They should be in the line above the _x or esc_html_x calls, not the sprintf and printf calls.

@renatho renatho merged commit c91777c into master Mar 10, 2021
@renatho renatho deleted the fix/phpcs branch March 10, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Maintenance Changes to non-production files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants