-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line alignment for bootstrap themes #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well! Just a small suggestion to add a comment saying that it's just to fix a conflict with themes. So we know that it doesn't have any purpose related to our styles. ;)
@@ -7,7 +7,7 @@ | |||
* | |||
* @version | |||
* 3.0.83 (July 02 2010) | |||
* | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for documentation purposes:
I thought it was a vendor file, but it seems there are some other changes that were applied to this file already, like this one: 9fc4a58
So probably it's not a big deal to change this file. Also, since that lib is not being maintained anymore, probably we won't have new versions to update this file. :)
Remove styling for the code container that Bootstrap accidentally adds.
576783d
to
04c2883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Remove styling for the code container that Bootstrap accidentally adds.
Bootstrap has its own containers but it applies styles for all containers.
Fixes #192
Changes proposed in this Pull Request
Testing instructions
Screenshot / Video
Before:
![CleanShot 2021-11-16 at 11 48 06@2x](https://user-images.githubusercontent.com/329356/141953370-18d75011-3913-4b6a-838a-556244b6ec15.png)
After:
![CleanShot 2021-11-16 at 11 44 55@2x](https://user-images.githubusercontent.com/329356/141953305-55d4a58a-d95b-4227-ac5c-e2976ca45c35.png)