Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

videomaker: Navigation (if needed) #4656

Closed
scruffian opened this issue Sep 20, 2021 · 3 comments · Fixed by #5059
Closed

videomaker: Navigation (if needed) #4656

scruffian opened this issue Sep 20, 2021 · 3 comments · Fixed by #5059
Assignees
Labels
[Theme] Videomaker Automatically generated label for videomaker.
Milestone

Comments

@scruffian
Copy link
Member

scruffian commented Sep 20, 2021

The Videomaker navigation looks like this:
Screenshot 2021-09-22 at 14 29 04

Screenshot 2021-09-22 at 14 29 18

We need to wait for WordPress/gutenberg#34783 to merge before we can achieve all of this.

@scruffian scruffian added the [Theme] Videomaker Automatically generated label for videomaker. label Sep 20, 2021
@scruffian scruffian added this to the videomaker milestone Sep 20, 2021
@scruffian
Copy link
Member Author

This will be fixed by #4832

@kjellr
Copy link
Contributor

kjellr commented Nov 12, 2021

I don't think the mockups above are relevant any longer, but I do think we need to make some adjustments to the way the navigation appears on desktop. Currently, the menu items are small and way over on the left edge of the page. This is easy to miss on medium-to-large screens.

menu

The theme mockups have these aligned more to the center column, so I think we should give that a try:

Menu Expanded-1
Menu Expanded

cc @beafialho

@beafialho
Copy link
Collaborator

The theme mockups have these aligned more to the center column, so I think we should give that a try:

Definitely, this looks more obvious 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Videomaker Automatically generated label for videomaker.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants