-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videomaker: Update Videomaker navigation #5059
Conversation
The main link font sizes seem pretty far off from target. Shouldn't they be much larger? This change also has changes to the awards block patterns. Perhaps branched from another branch with unnecessary changes? |
c0e0402
to
d593630
Compare
You're right, I updated the font sizes. The menu items should also be vertically centered. This is pretty hard to do with the currrent implementation and would take significant reworking, so if we want to do that I suggest we do it in a followup PR. |
Oh wait, my mistake. I can get it working in the site editor (But not in the customizer? 🤷) |
I'm seeing very bizarre vertical spacing here (and in
Not sure if this is viable, but this spacing bug would actually be solved if we adopted |
OK I worked out what was going on here - the social navigation was missing as you said above - you shouldn't need to add it from the site editor. The problem is that if you have justify content center then when there's not many menu items it looks like this: The alternative with space-between looks like this: @beafialho @kjellr which do you prefer? |
In that case can we merge this? :) |
@@ -7,6 +7,6 @@ | |||
<!-- wp:site-tagline /--> | |||
</div> | |||
<!-- /wp:group --> | |||
<!-- wp:navigation {"overlayMenu":"always","__unstableLocation":"primary","className":"is-style-blockbase-navigation-improved-responsive","layout":{"type":"flex","setCascadingProperties":true,"justifyContent":"right","orientation":"horizontal"}} /--> | |||
<!-- wp:navigation {"overlayMenu":"always","__unstableLocation":"primary","__unstableSocialLinks":"social","className":"is-style-blockbase-navigation-improved-responsive","layout":{"type":"flex","setCascadingProperties":true,"justifyContent":"right","orientation":"horizontal"}} /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this __unstableSocialLinks
attribute about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how we show a social navigation inside a navigation block. It allows us to hide the social links inside the overlay, while still allowing menus to be updated via the customizer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment, but this is working on my end. 👍
Changes proposed in this Pull Request:
Implements the idea in #4656 (comment)
Related issue(s):
#4656